]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
partitions/aix: fix usage of uninitialized lv_info and lvname structures
authorMauricio Faria de Oliveira <mfo@canonical.com>
Tue, 21 Aug 2018 14:01:00 +0000 (16:01 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 5 Sep 2018 08:30:45 +0000 (10:30 +0200)
commit951319686bdfa444da9174372caee22995178aaa
treeb730a93ec1bee39f3d6cc46cd330e87bf1bbe4cc
parent0bcbf30b75c27947f87d20a866bf86278bb63324
partitions/aix: fix usage of uninitialized lv_info and lvname structures

BugLink: https://bugs.launchpad.net/bugs/1787281
The if-block that sets a successful return value in aix_partition()
uses 'lvip[].pps_per_lv' and 'n[].name' potentially uninitialized.

For example, if 'numlvs' is zero or alloc_lvn() fails, neither is
initialized, but are used anyway if alloc_pvd() succeeds after it.

So, make the alloc_pvd() call conditional on their initialization.

This has been hit when attaching an apparently corrupted/stressed
AIX LUN, misleading the kernel to pr_warn() invalid data and hang.

    [...] partition (null) (11 pp's found) is not contiguous
    [...] partition (null) (2 pp's found) is not contiguous
    [...] partition (null) (3 pp's found) is not contiguous
    [...] partition (null) (64 pp's found) is not contiguous

Fixes: 6ceea22bbbc8 ("partitions: add aix lvm partition support files")
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
(cherry picked from commit 14cb2c8a6c5dae57ee3e2da10fa3db2b9087e39e)
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
block/partitions/aix.c