]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
rt2x00: do not pause queue unconditionally on error path
authorStanislaw Gruszka <sgruszka@redhat.com>
Tue, 19 Dec 2017 11:33:56 +0000 (12:33 +0100)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 12 Apr 2018 13:04:29 +0000 (10:04 -0300)
commit95391fb8c0d7b02fbc20ffbf389789604963db98
treeff597f1c63fbdd6ef735d7a31cb309d81cffb269
parent10314fe3c7a92f168256d82b85147a1e5571fdec
rt2x00: do not pause queue unconditionally on error path

BugLink: http://bugs.launchpad.net/bugs/1763366
[ Upstream commit 6dd80efd75ce7c2dbd9f117cf585ee2b33a42ee1 ]

Pausing queue without checking threshold is racy with txdone path.
Moreover we do not need pause queue on any error, but only if queue
is full - in case when we send RTS frame ( other cases of almost full
queue are already handled in rt2x00queue_write_tx_frame() ).

Patch fixes of theoretically possible problem of pausing empty
queue.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Tested-by: Enrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/net/wireless/ralink/rt2x00/rt2x00mac.c