]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
sbitmap: fix improper use of smp_mb__before_atomic()
authorAndrea Parri <andrea.parri@amarulasolutions.com>
Mon, 20 May 2019 17:23:57 +0000 (19:23 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit980ab6cc318c7357e9b139819fb3065dc0e8750d
tree64a2e317d798ccb9979a9d2ceee3025b522e7ce6
parentc6b7e72da79fbb9ed9daedc5a9a00bd3892a6c6b
sbitmap: fix improper use of smp_mb__before_atomic()

BugLink: https://bugs.launchpad.net/bugs/1838700
commit a0934fd2b1208458e55fc4b48f55889809fce666 upstream.

This barrier only applies to the read-modify-write operations; in
particular, it does not apply to the atomic_set() primitive.

Replace the barrier with an smp_mb().

Fixes: 6c0ca7ae292ad ("sbitmap: fix wakeup hang after sbq resize")
Cc: stable@vger.kernel.org
Reported-by: "Paul E. McKenney" <paulmck@linux.ibm.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
lib/sbitmap.c