]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ipv6: sr: remove SKB_GSO_IPXIP6 on End.D* actions
authorYuki Taguchi <tagyounit@gmail.com>
Mon, 20 Jan 2020 04:48:37 +0000 (13:48 +0900)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 6 Mar 2020 07:13:20 +0000 (02:13 -0500)
commit9bf11ce77e4e93b0926e41ed1167d7632793804d
treee825ae86c43274077c93bc1381d1775e087655e7
parent4b5835e6cf1e2004e76fe2f490c5790cbc288652
ipv6: sr: remove SKB_GSO_IPXIP6 on End.D* actions

BugLink: https://bugs.launchpad.net/bugs/1864261
[ Upstream commit 62ebaeaedee7591c257543d040677a60e35c7aec ]

After LRO/GRO is applied, SRv6 encapsulated packets have
SKB_GSO_IPXIP6 feature flag, and this flag must be removed right after
decapulation procedure.

Currently, SKB_GSO_IPXIP6 flag is not removed on End.D* actions, which
creates inconsistent packet state, that is, a normal TCP/IP packets
have the SKB_GSO_IPXIP6 flag. This behavior can cause unexpected
fallback to GSO on routing to netdevices that do not support
SKB_GSO_IPXIP6. For example, on inter-VRF forwarding, decapsulated
packets separated into small packets by GSO because VRF devices do not
support TSO for packets with SKB_GSO_IPXIP6 flag, and this degrades
forwarding performance.

This patch removes encapsulation related GSO flags from the skb right
after the End.D* action is applied.

Fixes: d7a669dd2f8b ("ipv6: sr: add helper functions for seg6local")
Signed-off-by: Yuki Taguchi <tagyounit@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/ipv6/seg6_local.c