]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
netfilter: ebtables: CONFIG_COMPAT: don't trust userland offsets
authorFlorian Westphal <fw@strlen.de>
Mon, 19 Feb 2018 00:24:15 +0000 (01:24 +0100)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 15 Mar 2018 21:29:11 +0000 (18:29 -0300)
commit9c64d82f9925565b02015e5bf9c0a4b37f33e68c
tree7d0dea710f702a39ca7339febf3ad48f63ec059b
parent54eaccf1c395340e93753a5369ca8ce660bd0db3
netfilter: ebtables: CONFIG_COMPAT: don't trust userland offsets

BugLink: http://bugs.launchpad.net/bugs/1756100
commit b71812168571fa55e44cdd0254471331b9c4c4c6 upstream.

We need to make sure the offsets are not out of range of the
total size.
Also check that they are in ascending order.

The WARN_ON triggered by syzkaller (it sets panic_on_warn) is
changed to also bail out, no point in continuing parsing.

Briefly tested with simple ruleset of
-A INPUT --limit 1/s' --log
plus jump to custom chains using 32bit ebtables binary.

Reported-by: <syzbot+845a53d13171abf8bf29@syzkaller.appspotmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
net/bridge/netfilter/ebtables.c