]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
serial: 8250_dw: Revert "Improve clock rate setting"
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 19 Jan 2018 16:02:05 +0000 (18:02 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Sat, 3 Feb 2018 17:40:58 +0000 (18:40 +0100)
commit9eefd042d8d5796e4267f17e3746cee7ae858503
tree7ed2ef8f810c7281ce80847a08bb270b9a2395de
parenta619d3fda087ead1c60951643e6edbc3671173d0
serial: 8250_dw: Revert "Improve clock rate setting"

BugLink: http://bugs.launchpad.net/bugs/1747169
commit c14b65feac9ebed649d6fe79c6b6d64d21d0287d upstream.

The commit

  de9e33bdfa22 ("serial: 8250_dw: Improve clock rate setting")

obviously tries to cure symptoms, and not a root cause.

The root cause is the non-flexible rate calculation inside the
corresponding clock driver. What we need is to provide maximum UART
divisor value to the clock driver to allow it do the job transparently
to the caller.

Since from the initial commit message I have got no clue which clock
driver actually needs to be amended, I leave this exercise to the people
who know better the case.

Moreover, it seems [1] the fix introduced a regression. And possible
even one more [2].

Taking above, revert the commit de9e33bdfa22 for now.

[1]: https://www.spinics.net/lists/linux-serial/msg28872.html
[2]: https://github.com/Dunedan/mbp-2016-linux/issues/29#issuecomment-357583782

Fixes: de9e33bdfa22 ("serial: 8250_dw: Improve clock rate setting")
Cc: Ed Blake <ed.blake@sondrel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/tty/serial/8250/8250_dw.c