]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
block, bfq: remove direct switch to an entity in higher class
authorPaolo Valente <paolo.valente@linaro.org>
Thu, 31 Aug 2017 06:46:30 +0000 (08:46 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 31 Aug 2017 14:20:29 +0000 (08:20 -0600)
commita02195ce864069c3aa41da792364bdfb3cdbc39f
treeb770c8818e37f257e18840b66652342a6971ec3b
parent80294c3bbf3ceb20530ee4aa44bbaf354222b021
block, bfq: remove direct switch to an entity in higher class

If the function bfq_update_next_in_service is invoked as a consequence
of the activation or requeueing of an entity, say E, and finds out
that E belongs to a higher-priority class than that of the current
next-in-service entity, then it sets next_in_service directly to
E. But this may lead to anomalous schedules, because E may happen not
be eligible for service, because its virtual start time is higher than
the system virtual time for its service tree.

This commit addresses this issue by simply removing this direct
switch.

Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Tested-by: Lee Tibbert <lee.tibbert@gmail.com>
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-wf2q.c