]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
commoncap: Handle memory allocation failure.
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tue, 10 Apr 2018 06:15:16 +0000 (15:15 +0900)
committerKhalid Elmously <khalid.elmously@canonical.com>
Tue, 12 Jun 2018 06:28:55 +0000 (02:28 -0400)
commita2810e04e82e5f906a7f8a30be603c034d3ca538
treec4ff636c6598a21784646bc8912cb0da906481bb
parent6feca343598422a4ae94ced0deb671fefe4179fb
commoncap: Handle memory allocation failure.

BugLink: http://bugs.launchpad.net/bugs/1775483
commit 1f5781725dcbb026438e77091c91a94f678c3522 upstream.

syzbot is reporting NULL pointer dereference at xattr_getsecurity() [1],
for cap_inode_getsecurity() is returning sizeof(struct vfs_cap_data) when
memory allocation failed. Return -ENOMEM if memory allocation failed.

[1] https://syzkaller.appspot.com/bug?id=a55ba438506fe68649a5f50d2d82d56b365e0107

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: 8db6c34f1dbc8e06 ("Introduce v3 namespaced file capabilities")
Reported-by: syzbot <syzbot+9369930ca44f29e60e2d@syzkaller.appspotmail.com>
Cc: stable <stable@vger.kernel.org> # 4.14+
Acked-by: Serge E. Hallyn <serge@hallyn.com>
Acked-by: James Morris <james.morris@microsoft.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
security/commoncap.c