]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
PM / devfreq: Fix potential NULL pointer dereference in governor_store
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 6 Dec 2017 20:20:15 +0000 (14:20 -0600)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 12 Apr 2018 13:04:20 +0000 (10:04 -0300)
commita4960fe85940c50daa5f19090b1a3f70f623f3d7
tree96790fbce6d6631fd02475cad6f6edc63c1e676c
parent3f68ef05fdd77b8ea6fc4de29821725795400589
PM / devfreq: Fix potential NULL pointer dereference in governor_store

BugLink: http://bugs.launchpad.net/bugs/1763366
[ Upstream commit 63f1e05f7fe9ca509c60154d6a833abf96eecdc9 ]

df->governor is being dereferenced before it is null checked,
hence there is a potential null pointer dereference.

Notice that df->governor is being null checked at line 1004:
if (df->governor) {, which implies it might be null.

Fix this by null checking df->governor before dereferencing it.

Addresses-Coverity-ID: 1401988 ("Dereference before null check")
Fixes: bcf23c79c4e4 ("PM / devfreq: Fix available_governor sysfs")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/devfreq/devfreq.c