]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ata: sata_dwc_460ex: fix crash on offline links without an attached drive
authorChristian Lamparter <chunkeey@googlemail.com>
Tue, 26 Apr 2016 09:03:03 +0000 (12:03 +0300)
committerTejun Heo <tj@kernel.org>
Tue, 10 May 2016 16:29:18 +0000 (12:29 -0400)
commita7e6de544c5c238a06935c96d27151432c94d2e6
tree3ad2fd28b7095c63a62b6ee69219188bc152b2b3
parent55e610cdd28c0ad3dce0652030c0296d549673f3
ata: sata_dwc_460ex: fix crash on offline links without an attached drive

This patch fixes Machine Check "Data Write PLB Error" which happens
when libata-sff's ata_sff_dev_select is trying to write into the
device_addr in order to select a drive. However, SATA has no master
or slave devices like the old ATA Bus, therefore selecting a
different drive is kind of pointless.

Data Write PLB Error
Oops: Machine check, sig: 7 [#1]
PowerPC 44x Platform
Modules linked in:
CPU: 0 PID: 508 Comm: scsi_eh_0 Not tainted 4.6.0-rc3-next-20160412+ #10
[...]
NIP [c027e820] ata_sff_dev_select+0x3c/0x44
LR [c027e810] ata_sff_dev_select+0x2c/0x44
Call Trace:
[cec31cd0] [c027da00] ata_sff_postreset+0x40/0xb4 (unreliable)
[cec31ce0] [c027a03c] ata_eh_reset+0x5cc/0x928
[cec31d60] [c027a840] ata_eh_recover+0x330/0x10bc
[cec31df0] [c027bae0] ata_do_eh+0x4c/0xa4
[...]

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/sata_dwc_460ex.c