]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 20 Jun 2018 03:54:53 +0000 (11:54 +0800)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:44:26 +0000 (19:44 -0600)
commita9620871f7bf8fe31e2ac4317866304782c7be74
tree2a7faa009099840f546a61e7791cbcde1220b859
parentd4c7348bf3dca859a5ece20d067ae5a9bb6f9962
usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()

BugLink: https://bugs.launchpad.net/bugs/1835972
[ Upstream commit 0602088b10a7c0b4e044a810678ef93d7cc5bf48 ]

The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16.7 are:

[FUNC] msleep
drivers/usb/gadget/udc/r8a66597-udc.c, 839:
msleep in init_controller
drivers/usb/gadget/udc/r8a66597-udc.c, 96:
init_controller in r8a66597_usb_disconnect
drivers/usb/gadget/udc/r8a66597-udc.c, 93:
spin_lock in r8a66597_usb_disconnect

[FUNC] msleep
drivers/usb/gadget/udc/r8a66597-udc.c, 835:
msleep in init_controller
drivers/usb/gadget/udc/r8a66597-udc.c, 96:
init_controller in r8a66597_usb_disconnect
drivers/usb/gadget/udc/r8a66597-udc.c, 93:
spin_lock in r8a66597_usb_disconnect

To fix these bugs, msleep() is replaced with mdelay().

This bug is found by my static analysis tool (DSAC-2) and checked by
my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/gadget/udc/r8a66597-udc.c