]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/amdgpu: revert "fix deadlock of reservation between cs and gpu reset v2"
authorChristian König <christian.koenig@amd.com>
Tue, 5 Sep 2017 13:10:50 +0000 (15:10 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 12 Sep 2017 18:23:30 +0000 (14:23 -0400)
commitaa4ec7ce7ec52c7230cfa73b06d79288b45fe1c9
treed17a8bce59d768b86a4cbc28f3b28eedac0b67cd
parent64d03abe6ee36ec48e997743e9397ae160eb508a
drm/amdgpu: revert "fix deadlock of reservation between cs and gpu reset v2"

This reverts commit 10e709cb296c98424c03408d23e3addeddcd4088.

The patch doesn't work at all:
1. The CS can still be blocked because of amdgpu_ctx_add_fence().
2. The order of submission isn't correct any more.
3. We could end up using freed up memory because we now drop the
   ctx reference to early.

This needs to be fixed cleanly by doing the context handling after the BO
handling, but this is a larger task just avoid the obvious crashes for now.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Monk Liu monk.liu@amd.com
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c