]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: bdisp: fix memleak on release
authorJohan Hovold <johan@kernel.org>
Thu, 10 Oct 2019 13:13:31 +0000 (10:13 -0300)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:42 +0000 (14:22 -0300)
commitaab84aebf39ae3544742db6f65cd709f2c052191
tree37942b3a17af53582786e0d08135f2b38e7c4a7c
parent71c05ee321080b9ba09d0881a38ed9f66c0a069b
media: bdisp: fix memleak on release

BugLink: https://bugs.launchpad.net/bugs/1857158
commit 11609a7e21f8cea42630350aa57662928fa4dc63 upstream.

If a process is interrupted while accessing the video device and the
device lock is contended, release() could return early and fail to free
related resources.

Note that the return value of the v4l2 release file operation is
ignored.

Fixes: 28ffeebbb7bd ("[media] bdisp: 2D blitter driver using v4l2 mem2mem framework")
Cc: stable <stable@vger.kernel.org> # 4.2
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/media/platform/sti/bdisp/bdisp-v4l2.c