]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
vhost_net: disable zerocopy by default
authorJason Wang <jasowang@redhat.com>
Mon, 17 Jun 2019 09:20:54 +0000 (05:20 -0400)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitb15cf44eb64e1505e2e7c8a104f00758286982aa
treee45b0428ca62cdbd913d0f4f791b897626eef612
parentfeb493e86bb22e345262a91a104616fe3fc3c9f4
vhost_net: disable zerocopy by default

BugLink: https://bugs.launchpad.net/bugs/1839036
[ Upstream commit 098eadce3c622c07b328d0a43dda379b38cf7c5e ]

Vhost_net was known to suffer from HOL[1] issues which is not easy to
fix. Several downstream disable the feature by default. What's more,
the datapath was split and datacopy path got the support of batching
and XDP support recently which makes it faster than zerocopy part for
small packets transmission.

It looks to me that disable zerocopy by default is more
appropriate. It cold be enabled by default again in the future if we
fix the above issues.

[1] https://patchwork.kernel.org/patch/3787671/

Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/vhost/net.c