]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
usbip: tools: fix atoi() on non-null terminated string
authorColin Ian King <colin.king@canonical.com>
Tue, 16 Oct 2018 18:03:43 +0000 (19:03 +0100)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:20:52 +0000 (14:20 -0300)
commitb1e4d80a0ad965fdf496765c07f9ac861d29ba00
treeb41ab89287ffff342318e4ebfe354891c35dee56
parentd30fa7223707e904205c81cd665cb2aa7e3525ad
usbip: tools: fix atoi() on non-null terminated string

BugLink: https://bugs.launchpad.net/bugs/1854975
[ Upstream commit e325808c0051b16729ffd472ff887c6cae5c6317 ]

Currently the call to atoi is being passed a single char string
that is not null terminated, so there is a potential read overrun
along the stack when parsing for an integer value.  Fix this by
instead using a 2 char string that is initialized to all zeros
to ensure that a 1 char read into the string is always terminated
with a \0.

Detected by cppcheck:
"Invalid atoi() argument nr 1. A nul-terminated string is required."

Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with vudc backend")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
tools/usb/usbip/libsrc/usbip_host_common.c