]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: usb-audio: Fix missing error check at mixer resolution test
authorTakashi Iwai <tiwai@suse.de>
Sat, 9 Nov 2019 18:16:58 +0000 (19:16 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 26 Nov 2019 12:16:20 +0000 (13:16 +0100)
commitb4a9df948f46553be2ea4b16f952fd8cf0240caa
treecb9a2ad04f8c40b5817362fc66e69782260e6db0
parentd777cd00380993a00c7819f658fe08202b2e1101
ALSA: usb-audio: Fix missing error check at mixer resolution test

BugLink: https://bugs.launchpad.net/bugs/1853915
commit 167beb1756791e0806365a3f86a0da10d7a327ee upstream.

A check of the return value from get_cur_mix_raw() is missing at the
resolution test code in get_min_max_with_quirks(), which may leave the
variable untouched, leading to a random uninitialized value, as
detected by syzkaller fuzzer.

Add the missing return error check for fixing that.

Reported-and-tested-by: syzbot+abe1ab7afc62c6bb6377@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191109181658.30368-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/usb/mixer.c