]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
team: no need to do team_notify_peers or team_mcast_rejoin when disabling port
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 22 Nov 2018 08:15:28 +0000 (16:15 +0800)
committerSultan Alsawaf <sultan.alsawaf@canonical.com>
Wed, 24 Jul 2019 15:45:04 +0000 (09:45 -0600)
commitb57411947e9455e1efb1d81ad87a4b095f4314cf
treea17e1da402f07a36eaba11a19ddfb58d74e65ad2
parent1b5164c2417ebe55768f79788a13997e6f07adbe
team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

BugLink: https://bugs.launchpad.net/bugs/1837161
[ Upstream commit 5ed9dc99107144f83b6c1bb52a69b58875baf540 ]

team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
will send multicast join group message to notify peers. We should do this when
enabling/changed to a new port. But it doesn't make sense to do it when a port
is disabled.

On the other hand, when we set mcast_rejoin_count to 2, and do a failover,
team_port_disable() will increase mcast_rejoin.count_pending to 2 and then
team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send
4 mcast rejoin messages at latest, which will make user confused. The same
with notify_peers.count.

Fix it by deleting team_notify_peers() and team_mcast_rejoin() in
team_port_disable().

Reported-by: Liang Li <liali@redhat.com>
Fixes: fc423ff00df3a ("team: add peer notification")
Fixes: 492b200efdd20 ("team: add support for sending multicast rejoins")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/team/team.c