]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
HID: holtek: test for sanity of intfdata
authorOliver Neukum <oneukum@suse.com>
Thu, 25 Jul 2019 13:13:33 +0000 (15:13 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 17 Sep 2019 16:02:18 +0000 (18:02 +0200)
commitb677a4645d938360baca4ed00895c4fe7c8c0175
tree4c1ded9d123b9bf9b6fc831cddc6e599096701d1
parent4c6ca0b2ddcab95ca4cf867f67f5125edc9793eb
HID: holtek: test for sanity of intfdata

BugLink: https://bugs.launchpad.net/bugs/1841652
commit 01ec0a5f19c8c82960a07f6c7410fc9e01d7fb51 upstream.

The ioctl handler uses the intfdata of a second interface,
which may not be present in a broken or malicious device, hence
the intfdata needs to be checked for NULL.

[jkosina@suse.cz: fix newly added spurious space]
Reported-by: syzbot+965152643a75a56737be@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/hid/hid-holtek-kbd.c