]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
platform/x86: wmi: Do not mix pages and kmalloc
authorKees Cook <keescook@chromium.org>
Wed, 20 Jun 2018 21:31:41 +0000 (14:31 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:45:24 +0000 (19:45 -0600)
commitb7ab4a8e7cdb8d402ef79902e3fc5ad02f7aa532
tree1971bb1a5214fdf85f44299e8ae03397ed850685
parent5ab7e47dfb612294e314102c903612114fe4f14b
platform/x86: wmi: Do not mix pages and kmalloc

BugLink: https://bugs.launchpad.net/bugs/1835972
commit 6fb741076a9fc53355e56dff2e2b46782b3a46d3 upstream.

The probe handler_data was being allocated with __get_free_pages()
for no reason I could find. The error path was using kfree(). Since
other things are happily using kmalloc() in the probe path, switch to
kmalloc() entirely. This fixes the error path mismatch and will avoid
issues with CONFIG_HARDENED_USERCOPY_PAGESPAN=y.

Reported-by: Mihai Donțu <mihai.dontu@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Mario Limonciello <Mario.limonciello@dell.com>
Cc: stable@vger.kernel.org
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/platform/x86/wmi.c