]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
libnvdimm, dimm: fix dpa reservation vs uninitialized label area
authorDan Williams <dan.j.williams@intel.com>
Fri, 6 Apr 2018 18:25:38 +0000 (11:25 -0700)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 6 Jun 2018 15:49:03 +0000 (11:49 -0400)
commitb9f4a08fe422c716c1302aae2c197f3dc9988c14
tree07927ddb2e6ae483c3cd7bb95ff6289789b29884
parent5c66454a0acd39b038068a18edb2476d3b193cf3
libnvdimm, dimm: fix dpa reservation vs uninitialized label area

BugLink: http://bugs.launchpad.net/bugs/1773233
commit c31898c8c711f2bbbcaebe802a55827e288d875a upstream.

At initialization time the 'dimm' driver caches a copy of the memory
device's label area and reserves address space for each of the
namespaces defined.

However, as can be seen below, the reservation occurs even when the
index blocks are invalid:

 nvdimm nmem0: nvdimm_init_config_data: len: 131072 rc: 0
 nvdimm nmem0: config data size: 131072
 nvdimm nmem0: __nd_label_validate: nsindex0 labelsize 1 invalid
 nvdimm nmem0: __nd_label_validate: nsindex1 labelsize 1 invalid
 nvdimm nmem0: : pmem-6025e505: 0x1000000000 @ 0xf50000000 reserve <-- bad

Gate dpa reservation on the presence of valid index blocks.

Cc: <stable@vger.kernel.org>
Fixes: 4a826c83db4e ("libnvdimm: namespace indices: read and validate")
Reported-by: Krzysztof Rusocki <krzysztof.rusocki@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Acked-by: Brad Figg <brad.figg@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/nvdimm/dimm.c