]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: vmaster: Propagate slave error
authorTakashi Iwai <tiwai@suse.de>
Thu, 8 Mar 2018 07:26:48 +0000 (08:26 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commitbdae57d3455ed75f2aaa4dcebf74f00d2f5f13a8
treefb93f48024a44bc771b41687cd4a003a294261b2
parent824dc27433c431496d8ca97bdddd37626cb4626a
ALSA: vmaster: Propagate slave error

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit 2e2c177ca84aff092c3c96714b0f6a12900f3946 ]

In slave_update() of vmaster code ignores the error from the slave
get() callback and copies the values.  It's not only about the missing
error code but also that this may potentially lead to a leak of
uninitialized variables when the slave get() don't clear them.

This patch fixes slave_update() not to copy the potentially
uninitialized values when an error is returned from the slave get()
callback, and to propagate the error value properly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/core/vmaster.c