]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
gpu: ipu-v3: prg: avoid possible array underflow
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Mar 2018 16:19:57 +0000 (17:19 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commitc3c0b694aa2bf860c196dab9632a7544cb7043c3
treee19dd9b0ffae47ea1411ea489e94d76f5de8ff9d
parentbe4d20a97dc1d77e9923404ecc33d86b8b2be982
gpu: ipu-v3: prg: avoid possible array underflow

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit 746d024c3211813946b319411aeb2b47767f8fb0 ]

gcc-8 reports that we access an array with a negative index
in an error case:

drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable':
drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds]

This moves the range check in front of the first time that
variable gets used.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/ipu-v3/ipu-prg.c