]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: ns2: Fix off by one bugs in ns2_pinmux_enable()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 26 Sep 2019 08:14:26 +0000 (11:14 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 26 Nov 2019 12:15:55 +0000 (13:15 +0100)
commitc74880013f534f1a4c45f3dc4c92050a39c7648f
tree13b7020827d09e77b1e63d6dbccb001f6b3acca4
parent23c8f6a0f77855da319b7b7de37d7b9927525b35
pinctrl: ns2: Fix off by one bugs in ns2_pinmux_enable()

BugLink: https://bugs.launchpad.net/bugs/1853208
[ Upstream commit 39b65fbb813089e366b376bd8acc300b6fd646dc ]

The pinctrl->functions[] array has pinctrl->num_functions elements and
the pinctrl->groups[] array is the same way.  These are set in
ns2_pinmux_probe().  So the > comparisons should be >= so that we don't
read one element beyond the end of the array.

Fixes: b5aa1006e4a9 ("pinctrl: ns2: add pinmux driver support for Broadcom NS2 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190926081426.GB2332@mwanda
Acked-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/pinctrl/bcm/pinctrl-ns2-mux.c