]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
perf tests evsel-tp-sched: Fix bitwise operator
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 22 Jan 2019 23:34:39 +0000 (17:34 -0600)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitcf0e3685f8a29d29010c313fec24c28f962087ea
treecc0de88985d02833eec19a93418b46a19afab6cc
parente70998c0925cde5afa08b0c31decc987f1ad1808
perf tests evsel-tp-sched: Fix bitwise operator

BugLink: https://bugs.launchpad.net/bugs/1837664
commit 489338a717a0dfbbd5a3fabccf172b78f0ac9015 upstream.

Notice that the use of the bitwise OR operator '|' always leads to true
in this particular case, which seems a bit suspicious due to the context
in which this expression is being used.

Fix this by using bitwise AND operator '&' instead.

This bug was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
Link: http://lkml.kernel.org/r/20190122233439.GA5868@embeddedor
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
tools/perf/tests/evsel-tp-sched.c