]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
USB: serial: ir-usb: fix IrLAP framing
authorJohan Hovold <johan@kernel.org>
Wed, 22 Jan 2020 10:15:28 +0000 (11:15 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 6 Mar 2020 07:13:20 +0000 (02:13 -0500)
commitd5edb634b5b1bff08ea483fe4635bd09eb15ac95
treee6e185b178b48129188d6553e87d6d85b554993f
parent75df183af193105b9a895411db4eb03320784236
USB: serial: ir-usb: fix IrLAP framing

BugLink: https://bugs.launchpad.net/bugs/1864904
commit 38c0d5bdf4973f9f5a888166e9d3e9ed0d32057a upstream.

Commit f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework")
switched to using the generic write implementation which may combine
multiple write requests into larger transfers. This can break the IrLAP
protocol where end-of-frame is determined using the USB short packet
mechanism, for example, if multiple frames are sent in rapid succession.

Fixes: f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework")
Cc: stable <stable@vger.kernel.org> # 2.6.35
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/usb/serial/ir-usb.c