]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/i915: Don't oops during modeset shutdown after lpe audio deinit
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 5 Nov 2018 19:46:04 +0000 (21:46 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:59:28 +0000 (19:59 -0600)
commitd8b47e259e14d94b2b8340d4eed55b4749bd2317
tree24065a49d046eabf8ef0658e8af9f6ab45d167fb
parent914503fea491824a87d895e413ef406c8fae6ee7
drm/i915: Don't oops during modeset shutdown after lpe audio deinit

BugLink: https://bugs.launchpad.net/bugs/1836802
commit 6a8915d0f8cf323e1beb792a33095cf652db4056 upstream.

We deinit the lpe audio device before we call
drm_atomic_helper_shutdown(), which means the platform device
may already be gone when it comes time to shut down the crtc.
As we don't know when the last reference to the platform
device gets dropped by the audio driver we can't assume that
the device and its data are still around when turning off the
crtc. Mark the platform device as gone as soon as we do the
audio deinit.

Cc: stable@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181105194604.6994-1-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
(cherry picked from commit f45a7977d1140c11f334e01a9f77177ed68e3bfa)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/drm/i915/intel_lpe_audio.c