]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
tcp: verify the checksum of the first data segment in a new connection
authorFrank van der Linden <fllinden@amazon.com>
Tue, 12 Jun 2018 23:09:37 +0000 (23:09 +0000)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 9 Nov 2018 19:00:03 +0000 (17:00 -0200)
commitdd319c074f132518690f05aa91b51fc11c4d2d1b
treeff1ef52e4c5d6bd21e53e3b4f24634e210d12ead
parent3eda3a15f51fdeb0c1622b073b55671ac9a60915
tcp: verify the checksum of the first data segment in a new connection

BugLink: http://bugs.launchpad.net/bugs/1800537
[ Upstream commit 4fd44a98ffe0d048246efef67ed640fdf2098a62 ]

commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash
table") introduced an optimization for the handling of child sockets
created for a new TCP connection.

But this optimization passes any data associated with the last ACK of the
connection handshake up the stack without verifying its checksum, because it
calls tcp_child_process(), which in turn calls tcp_rcv_state_process()
directly.  These lower-level processing functions do not do any checksum
verification.

Insert a tcp_checksum_complete call in the TCP_NEW_SYN_RECEIVE path to
fix this.

Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Frank van der Linden <fllinden@amazon.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Balbir Singh <bsingharora@gmail.com>
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/ipv4/tcp_ipv4.c
net/ipv6/tcp_ipv6.c