]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
6lowpan: Off by one handling ->nexthdr
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Apr 2019 05:34:16 +0000 (08:34 +0300)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commite51899706dcfe89b8790e9071108d2b08cb89823
tree25ccc9d2d98be90ba15d0db775a91f9406dd1219
parenta39934545486ccb2531d9709441219b335543905
6lowpan: Off by one handling ->nexthdr

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit f57c4bbf34439531adccd7d3a4ecc14f409c1399 ]

NEXTHDR_MAX is 255.  What happens here is that we take a u8 value
"hdr->nexthdr" from the network and then look it up in
lowpan_nexthdr_nhcs[].  The problem is that if hdr->nexthdr is 0xff then
we read one element beyond the end of the array so the array needs to
be one element larger.

Fixes: 92aa7c65d295 ("6lowpan: add generic nhc layer interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Acked-by: Alexander Aring <aring@mojatatu.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/6lowpan/nhc.c