]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
virtio-net: disable NAPI only when enabled during XDP set
authorJason Wang <jasowang@redhat.com>
Wed, 28 Feb 2018 10:20:04 +0000 (18:20 +0800)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 15 Mar 2018 13:28:18 +0000 (08:28 -0500)
commite527a479912ed8e6baeab0361cb4624a718ed099
tree27bb43448202a91cd8c464a232565123384c5207
parent7aad491b36e99668f080d0ad567e1c3b58f3af00
virtio-net: disable NAPI only when enabled during XDP set

BugLink: http://bugs.launchpad.net/bugs/1755179
[ Upstream commit 4e09ff5362843dff3accfa84c805c7f3a99de9cd ]

We try to disable NAPI to prevent a single XDP TX queue being used by
multiple cpus. But we don't check if device is up (NAPI is enabled),
this could result stall because of infinite wait in
napi_disable(). Fixing this by checking device state through
netif_running() before.

Fixes: 4941d472bf95b ("virtio-net: do not reset during XDP set")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/net/virtio_net.c