]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
x86/xen: Return from panic notifier
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Mon, 30 Sep 2019 20:44:41 +0000 (16:44 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 13 Nov 2019 23:47:34 +0000 (18:47 -0500)
commite64abd0660209e383527aa5ef93e4987cfb238c6
tree0f056601ac50de1058d1b40aa55624dbb89a1519
parente0bb04e45bc5087d69614b872d203c0eb352122b
x86/xen: Return from panic notifier

BugLink: https://bugs.launchpad.net/bugs/1852492
[ Upstream commit c6875f3aacf2a5a913205accddabf0bfb75cac76 ]

Currently execution of panic() continues until Xen's panic notifier
(xen_panic_event()) is called at which point we make a hypercall that
never returns.

This means that any notifier that is supposed to be called later as
well as significant part of panic() code (such as pstore writes from
kmsg_dump()) is never executed.

There is no reason for xen_panic_event() to be this last point in
execution since panic()'s emergency_restart() will call into
xen_emergency_restart() from where we can perform our hypercall.

Nevertheless, we will provide xen_legacy_crash boot option that will
preserve original behavior during crash. This option could be used,
for example, if running kernel dumper (which happens after panic
notifiers) is undesirable.

Reported-by: James Dingwall <james@dingwall.me.uk>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
Documentation/admin-guide/kernel-parameters.txt
arch/x86/xen/enlighten.c