]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
HID: multitouch: change for touch height/width
authorHungNien Chen <hn.chen@weidahitech.com>
Mon, 6 Mar 2017 03:30:14 +0000 (11:30 +0800)
committerJiri Kosina <jkosina@suse.cz>
Mon, 6 Mar 2017 13:48:32 +0000 (14:48 +0100)
commite9d0a26d34818e0f9340316f8016129231560966
tree91bccc7785f4a1069ad8dd7bd4c2cc52a1c812c8
parent81bbef23db51c0b450d90607fbbc2ad80ee0d43f
HID: multitouch: change for touch height/width

Quoting  from Jonathan Clarke in previous thread(2017/01/24):

"This division by 2 was added along with the touch width/height fields 6 years
ago so that those fields 'match the visual scale of the touch' for a specific
device (3M PCT)" "The scaling is also discarding information about touch size
(1 bit for each of width/height) which is useful for any application that wants
to know about it."

Jonathan mentioned just what I thought in a new project recently.  It dosen't
make sense to discard 1 bit width/height in general case according to the spec
in multi-touch-protocol.txt so I would like to make a slight change here.

A quirk MT_QUIRK_TOUCH_SIZE_SCALING was added to service devices like 3M PCT
with a special visual scale and the division by 2 only take effect with devices
like that.

[jkosina@suse.cz: reformat changelog]
Signed-off-by: HungNien Chen <hn.chen@weidahitech.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-multitouch.c