]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
powerpc/tools: Don't quote $objdump in scripts
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Oct 2019 00:47:30 +0000 (11:47 +1100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:47:27 +0000 (23:47 -0500)
commitee5dcab88a9050d1cabf65695d27dfbf4bcebaa5
treef42149f68b7dba44839b29b1cd1a1d9f1ad05e54
parentfd3c2f7ffd0c97e89f972d942988890d6be98a87
powerpc/tools: Don't quote $objdump in scripts

BugLink: https://bugs.launchpad.net/bugs/1860602
[ Upstream commit e44ff9ea8f4c8a90c82f7b85bd4f5e497c841960 ]

Some of our scripts are passed $objdump and then call it as
"$objdump". This doesn't work if it contains spaces because we're
using ccache, for example you get errors such as:

  ./arch/powerpc/tools/relocs_check.sh: line 48: ccache ppc64le-objdump: No such file or directory
  ./arch/powerpc/tools/unrel_branch_check.sh: line 26: ccache ppc64le-objdump: No such file or directory

Fix it by not quoting the string when we expand it, allowing the shell
to do the right thing for us.

Fixes: a71aa05e1416 ("powerpc: Convert relocs_check to a shell script using grep")
Fixes: 4ea80652dc75 ("powerpc/64s: Tool to flag direct branches from unrelocated interrupt vectors")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191024004730.32135-1-mpe@ellerman.id.au
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
arch/powerpc/tools/relocs_check.sh
arch/powerpc/tools/unrel_branch_check.sh