]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
iwlwifi: mvm: fix error checking for multi/broadcast sta
authorJohannes Berg <johannes.berg@intel.com>
Thu, 22 Feb 2018 12:51:21 +0000 (13:51 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 27 Aug 2018 14:40:05 +0000 (16:40 +0200)
commitf125a67a49ba1177a670cc01f6a0945e24d337e2
treea6ef48fecbfa840d75abf4509db18b28c1eb22c2
parent4c64370f665179f412e36ccfeda6a67cf89e4226
iwlwifi: mvm: fix error checking for multi/broadcast sta

BugLink: http://bugs.launchpad.net/bugs/1786352
[ Upstream commit 75fd4fec3e4c43b131c7c4958adb3ab9f1665513 ]

The earlier patch called the station add functions but didn't
assign their return value to the ret variable, so that the
checks for it were meaningless. Fix that.

Found by smatch:

.../mac80211.c:2560 iwl_mvm_start_ap_ibss() warn: we tested 'ret' before and it was 'false'
.../mac80211.c:2563 iwl_mvm_start_ap_ibss() warn: we tested 'ret' before and it was 'false'

Fixes: 3a89411cd31c ("iwlwifi: mvm: fix assert 0x2B00 on older FWs")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c