]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
crypto: poly1305 - remove ->setkey() method
authorEric Biggers <ebiggers@google.com>
Wed, 3 Jan 2018 19:16:25 +0000 (11:16 -0800)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 22 Feb 2018 14:15:52 +0000 (08:15 -0600)
commitf38e1588158a5e4090cf0273e8a5334e0318a0a1
tree1a6c363c3caeb8ba136814b013bd695c11efeb12
parent2358cffad025ad5247b411471572e7628600dcac
crypto: poly1305 - remove ->setkey() method

BugLink: http://bugs.launchpad.net/bugs/1751064
commit a16e772e664b9a261424107784804cffc8894977 upstream.

Since Poly1305 requires a nonce per invocation, the Linux kernel
implementations of Poly1305 don't use the crypto API's keying mechanism
and instead expect the key and nonce as the first 32 bytes of the data.
But ->setkey() is still defined as a stub returning an error code.  This
prevents Poly1305 from being used through AF_ALG and will also break it
completely once we start enforcing that all crypto API users (not just
AF_ALG) call ->setkey() if present.

Fix it by removing crypto_poly1305_setkey(), leaving ->setkey as NULL.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
arch/x86/crypto/poly1305_glue.c
crypto/poly1305_generic.c
include/crypto/poly1305.h