]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
mm/tlb: Remove tlb_remove_table() non-concurrent condition
authorPeter Zijlstra <peterz@infradead.org>
Fri, 19 Oct 2018 22:38:00 +0000 (00:38 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 23 Oct 2018 09:13:37 +0000 (11:13 +0200)
commitfbc39525ed5a591defcf66c7b32a0ab6b97b0c84
tree721fbe8a261d9fc6e4516087a6a1a024a9d71051
parent7607e716b3457324015202b8fdd97cea85525583
mm/tlb: Remove tlb_remove_table() non-concurrent condition

BugLink: https://launchpad.net/bugs/1798897
Will noted that only checking mm_users is incorrect; we should also
check mm_count in order to cover CPUs that have a lazy reference to
this mm (and could do speculative TLB operations).

If removing this turns out to be a performance issue, we can
re-instate a more complete check, but in tlb_table_flush() eliding the
call_rcu_sched().

Fixes: 267239116987 ("mm, powerpc: move the RCU page-table freeing into generic code")
Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Rik van Riel <riel@surriel.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit a6f572084fbee8b30f91465f4a085d7a90901c57)
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
mm/memory.c