]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 28 Sep 2018 18:03:59 +0000 (21:03 +0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitffa9542e52faa45865b7dff537908ca5836f559a
tree14f7e4b6151e49624c9cfeade43e63694e74a659
parent54a7d09978fb473fbe73eceb6272c4883ca475d3
drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers

BugLink: https://bugs.launchpad.net/bugs/1838116
[ Upstream commit c978ae9bde582e82a04c63a4071701691dd8b35c ]

We aren't supposed to force a stop+start between every i2c msg
when performing multi message transfers. This should eg. cause
the DDC segment address to be reset back to 0 between writing
the segment address and reading the actual EDID extension block.

To quote the E-DDC spec:
"... this standard requires that the segment pointer be
 reset to 00h when a NO ACK or a STOP condition is received."

Since we're going to touch this might as well consult the
I2C_M_STOP flag to determine whether we want to force the stop
or not.

Cc: Brian Vincent <brainn@gmail.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=108081
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180928180403.22499-1-ville.syrjala@linux.intel.com
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/drm/drm_dp_mst_topology.c