]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
HID: apple: Fix stuck function keys when using FN
authorJoao Moreno <mail@joaomoreno.com>
Tue, 3 Sep 2019 14:46:32 +0000 (16:46 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 16 Oct 2019 09:55:43 +0000 (11:55 +0200)
commitffc912e5e177468aef16049a68c82c267a783ad3
tree25e47172369d5614e08fe169c316ac3f00117801
parent1a13e64864334f80e9f35f00db69ef19b3ea81a0
HID: apple: Fix stuck function keys when using FN

BugLink: https://bugs.launchpad.net/bugs/1848274
[ Upstream commit aec256d0ecd561036f188dbc8fa7924c47a9edfd ]

This fixes an issue in which key down events for function keys would be
repeatedly emitted even after the user has raised the physical key. For
example, the driver fails to emit the F5 key up event when going through
the following steps:
- fnmode=1: hold FN, hold F5, release FN, release F5
- fnmode=2: hold F5, hold FN, release F5, release FN

The repeated F5 key down events can be easily verified using xev.

Signed-off-by: Joao Moreno <mail@joaomoreno.com>
Co-developed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/hid/hid-apple.c