]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
ASoC: davinci-mcasp: Fix clang warning without CONFIG_PM
authorArnd Bergmann <arnd@arndb.de>
Thu, 7 Mar 2019 10:11:30 +0000 (11:11 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 13 Aug 2019 12:11:36 +0000 (14:11 +0200)
commitc99b0d6932e93c97e02f66f1db121c03b1e0d929
tree4468e1a655e6a5ee89d93d9dce946e2ccd20ae78
parent0cb12629c6e23f87630175007bd79d81de967a4f
ASoC: davinci-mcasp: Fix clang warning without CONFIG_PM

BugLink: https://bugs.launchpad.net/bugs/1837517
[ Upstream commit 8ca5104715cfd14254ea5aecc390ae583b707607 ]

Building with clang shows a variable that is only used by the
suspend/resume functions but defined outside of their #ifdef block:

sound/soc/ti/davinci-mcasp.c:48:12: error: variable 'context_regs' is not needed and will not be emitted

We commonly fix these by marking the PM functions as __maybe_unused,
but here that would grow the davinci_mcasp structure, so instead
add another #ifdef here.

Fixes: 1cc0c054f380 ("ASoC: davinci-mcasp: Convert the context save/restore to use array")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/soc/ti/davinci-mcasp.c