]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
i2c: iop3xx: Fix memory leak in probe error path
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 13 Jan 2020 17:29:54 +0000 (18:29 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 06:00:53 +0000 (01:00 -0500)
commit404d2461ac559ef34e980d9e7bc3b6066c0f215f
treec447304c1f75bac6b9625b608a3f88d911d487bd
parent5ee43d53828f77a9e0dc1a7749c399e0aceeb4a4
i2c: iop3xx: Fix memory leak in probe error path

BugLink: https://bugs.launchpad.net/bugs/1862429
commit e64175776d06a8ceebbfd349d7e66a4a46ca39ef upstream.

When handling devm_gpiod_get_optional() errors, free the memory already
allocated.  This fixes Smatch warnings:

    drivers/i2c/busses/i2c-iop3xx.c:437 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'
    drivers/i2c/busses/i2c-iop3xx.c:442 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'

Fixes: fdb7e884ad61 ("i2c: iop: Use GPIO descriptors")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/i2c/busses/i2c-iop3xx.c