]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
net: cdc_ncm: Signedness bug in cdc_ncm_set_dgram_size()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Nov 2019 18:28:31 +0000 (21:28 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 4 Dec 2019 09:29:26 +0000 (10:29 +0100)
commit4447be665fb320e0ecefea58062053d08e5fe62e
tree85c5a7780dabe81a8ee29fab81ef9ade06adea31
parent55257c753849b5abd75d6baed41276fc8c6691e8
net: cdc_ncm: Signedness bug in cdc_ncm_set_dgram_size()

BugLink: https://bugs.launchpad.net/bugs/1853882
commit a56dcc6b455830776899ce3686735f1172e12243 upstream.

This code is supposed to test for negative error codes and partial
reads, but because sizeof() is size_t (unsigned) type then negative
error codes are type promoted to high positive values and the condition
doesn't work as expected.

Fixes: 332f989a3b00 ("CDC-NCM: handle incomplete transfer of MTU")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/usb/cdc_ncm.c