]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
r8169: fix issue with forced threading in combination with shared interrupts
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 29 Oct 2020 09:18:53 +0000 (10:18 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:02:29 +0000 (12:02 +0100)
commitfd3150aeb4f34b3460c0a851255abf3ebce3ee0f
tree59dfc7fe64df955e6d0eca8e6aa640136994980e
parent17997b92dc25845b755b72d5cab522626c0acc97
r8169: fix issue with forced threading in combination with shared interrupts

BugLink: https://bugs.launchpad.net/bugs/1904445
[ Upstream commit 2734a24e6e5d18522fbf599135c59b82ec9b2c9e ]

As reported by Serge flag IRQF_NO_THREAD causes an error if the
interrupt is actually shared and the other driver(s) don't have this
flag set. This situation can occur if a PCI(e) legacy interrupt is
used in combination with forced threading.
There's no good way to deal with this properly, therefore we have to
remove flag IRQF_NO_THREAD. For fixing the original forced threading
issue switch to napi_schedule().

Fixes: 424a646e072a ("r8169: fix operation under forced interrupt threading")
Link: https://www.spinics.net/lists/netdev/msg694960.html
Reported-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Link: https://lore.kernel.org/r/b5b53bfe-35ac-3768-85bf-74d1290cf394@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/net/ethernet/realtek/r8169_main.c