]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
xen/gntdev: fix gntdev_mmap() error exit path
authorJuergen Gross <jgross@suse.com>
Fri, 23 Apr 2021 05:40:38 +0000 (07:40 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 18 Jun 2021 09:07:34 +0000 (11:07 +0200)
commit73f389451ac1e6d7a7e46d8856327816c5374ad8
tree062e3d76ceb7479d5ebda476ca26c31c8b09c4bf
parent2088c361f49b204aaada39f82df37ffcbca62715
xen/gntdev: fix gntdev_mmap() error exit path

BugLink: https://bugs.launchpad.net/bugs/1931292
commit 970655aa9b42461f8394e4457307005bdeee14d9 upstream.

Commit d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert")
introduced an error in gntdev_mmap(): in case the call of
mmu_interval_notifier_insert_locked() fails the exit path should not
call mmu_interval_notifier_remove(), as this might result in NULL
dereferences.

One reason for failure is e.g. a signal pending for the running
process.

Fixes: d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert")
Cc: stable@vger.kernel.org
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Link: https://lore.kernel.org/r/20210423054038.26696-1-jgross@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/xen/gntdev.c