]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
net: enetc: fix link error again
authorArnd Bergmann <arnd@arndb.de>
Thu, 22 Apr 2021 13:35:11 +0000 (15:35 +0200)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 24 May 2021 23:46:42 +0000 (17:46 -0600)
commit867886c848634cb6ffa99a6ab53900196815b58d
tree44719209be24d0d9c6a9ce613a0d9138a3669245
parent34a54497198157856317174c3de5238d60bac1c0
net: enetc: fix link error again

BugLink: https://bugs.launchpad.net/bugs/1929455
[ Upstream commit 74c97ea3b61e4ce149444f904ee8d4fc7073505b ]

A link time bug that I had fixed before has come back now that
another sub-module was added to the enetc driver:

ERROR: modpost: "enetc_ierb_register_pf" [drivers/net/ethernet/freescale/enetc/fsl-enetc.ko] undefined!

The problem is that the enetc Makefile is not actually used for
the ierb module if that is the only built-in driver in there
and everything else is a loadable module.

Fix it by always entering the directory this time, regardless
of which symbols are configured. This should reliably fix the
problem and prevent it from coming back another time.

Fixes: 112463ddbe82 ("net: dsa: felix: fix link error")
Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/net/ethernet/freescale/Makefile