]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
Xen/gntdev: correct dev_bus_addr handling in gntdev_map_grant_pages()
authorJan Beulich <jbeulich@suse.com>
Mon, 15 Feb 2021 07:51:07 +0000 (08:51 +0100)
committerAndrea Righi <andrea.righi@canonical.com>
Mon, 1 Mar 2021 14:56:48 +0000 (15:56 +0100)
commita0659c95c7c6b2284d06ccadda1d33cad3e39d39
tree5bd082edd9d5ff6d24838ecd2db8551de4c0d7ad
parent5edd517a279aa7f1098df350063d3b83c6fe9898
Xen/gntdev: correct dev_bus_addr handling in gntdev_map_grant_pages()

commit dbe5283605b3bc12ca45def09cc721a0a5c853a2 upstream.

We may not skip setting the field in the unmap structure when
GNTMAP_device_map is in use - such an unmap would fail to release the
respective resources (a page ref in the hypervisor). Otoh the field
doesn't need setting at all when GNTMAP_device_map is not in use.

To record the value for unmapping, we also better don't use our local
p2m: In particular after a subsequent change it may not have got updated
for all the batch elements. Instead it can simply be taken from the
respective map's results.

We can additionally avoid playing this game altogether for the kernel
part of the mappings in (x86) PV mode.

This is part of XSA-361.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: stable@vger.kernel.org
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
drivers/xen/gntdev.c