]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
staging: comedi: addi_apci_1032: Fix endian problem for COS sample
authorIan Abbott <abbotti@mev.co.uk>
Tue, 23 Feb 2021 14:30:42 +0000 (14:30 +0000)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 17 Mar 2021 18:48:56 +0000 (13:48 -0500)
commitbc72c778fb1ef8c7c615696b07b9396034278a56
treeff7ab83c3a5c938bff63871359fe375df0f3cae4
parentec7529daca3d47f07c8652327aa9e34a9eab76a2
staging: comedi: addi_apci_1032: Fix endian problem for COS sample

BugLink: https://bugs.launchpad.net/bugs/1919492
commit 25317f428a78fde71b2bf3f24d05850f08a73a52 upstream.

The Change-Of-State (COS) subdevice supports Comedi asynchronous
commands to read 16-bit change-of-state values.  However, the interrupt
handler is calling `comedi_buf_write_samples()` with the address of a
32-bit integer `&s->state`.  On bigendian architectures, it will copy 2
bytes from the wrong end of the 32-bit integer.  Fix it by transferring
the value via a 16-bit integer.

Fixes: 6bb45f2b0c86 ("staging: comedi: addi_apci_1032: use comedi_buf_write_samples()")
Cc: <stable@vger.kernel.org> # 3.19+
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20210223143055.257402-2-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/staging/comedi/drivers/addi_apci_1032.c