]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
iwlwifi: pcie: don't disable interrupts for reg_lock
authorJohannes Berg <johannes.berg@intel.com>
Wed, 10 Feb 2021 11:56:27 +0000 (13:56 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 8 Apr 2021 20:42:48 +0000 (15:42 -0500)
commitd97c29eeb0f8091c56aaa6af06c4eec0ff2aba40
treebb1cb628bbe8976d0a70e2030b687b047caad981
parentcd01d6ae59b6b498abbc56e3a47b31990d720f75
iwlwifi: pcie: don't disable interrupts for reg_lock

BugLink: https://bugs.launchpad.net/bugs/1923069
[ Upstream commit 874020f8adce535cd318af1768ffe744251b6593 ]

The only thing we do touching the device in hard interrupt context
is, at most, writing an interrupt ACK register, which isn't racing
in with anything protected by the reg_lock.

Thus, avoid disabling interrupts here for potentially long periods
of time, particularly long periods have been observed with dumping
of firmware memory (leading to lockup warnings on some devices.)

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20210210135352.da916ab91298.I064c3e7823b616647293ed97da98edefb9ce9435@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
drivers/net/wireless/intel/iwlwifi/pcie/trans.c
drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c
drivers/net/wireless/intel/iwlwifi/pcie/tx.c