]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ALSA: pcm: Clear the full allocated memory at hw_params
authorTakashi Iwai <tiwai@suse.de>
Fri, 18 Dec 2020 14:56:25 +0000 (15:56 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Fri, 8 Jan 2021 11:25:26 +0000 (12:25 +0100)
commitdedb1327bcd3173c5e30a0230be611d27cb7b71b
treef0db24b81662c0489567076a97806d262fd6aa26
parentf22231e1e91828654f22ab9ef71ca64883cadcba
ALSA: pcm: Clear the full allocated memory at hw_params

BugLink: https://bugs.launchpad.net/bugs/1910742
[ Upstream commit 618de0f4ef11acd8cf26902e65493d46cc20cc89 ]

The PCM hw_params core function tries to clear up the PCM buffer
before actually using for avoiding the information leak from the
previous usages or the usage before a new allocation.  It performs the
memset() with runtime->dma_bytes, but this might still leave some
remaining bytes untouched; namely, the PCM buffer size is aligned in
page size for mmap, hence runtime->dma_bytes doesn't necessarily cover
all PCM buffer pages, and the remaining bytes are exposed via mmap.

This patch changes the memory clearance to cover the all buffer pages
if the stream is supposed to be mmap-ready (that guarantees that the
buffer size is aligned in page size).

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201218145625.2045-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
sound/core/pcm_native.c