]> git.proxmox.com Git - mirror_ubuntu-impish-kernel.git/commit
seq_buf: Fix overflow in seq_buf_putmem_hex()
authorYun Zhou <yun.zhou@windriver.com>
Sat, 26 Jun 2021 03:21:55 +0000 (11:21 +0800)
committerAndrea Righi <andrea.righi@canonical.com>
Mon, 2 Aug 2021 11:26:48 +0000 (13:26 +0200)
commit63673ae79b898f936605bd92d6f6960ad339e58d
tree10ca1b96fd67a9d68c4fce078ece0f3150a19fd6
parent74803f361fe3c4ac240c98e4f59c8329a863dd1d
seq_buf: Fix overflow in seq_buf_putmem_hex()

There's two variables being increased in that loop (i and j), and i
follows the raw data, and j follows what is being written into the buffer.
We should compare 'i' to MAX_MEMHEX_BYTES or compare 'j' to HEX_CHARS.
Otherwise, if 'j' goes bigger than HEX_CHARS, it will overflow the
destination buffer.

Link: https://lore.kernel.org/lkml/20210625122453.5e2fe304@oasis.local.home/
Link: https://lkml.kernel.org/r/20210626032156.47889-1-yun.zhou@windriver.com
Cc: stable@vger.kernel.org
Fixes: 5e3ca0ec76fce ("ftrace: introduce the "hex" output method")
Signed-off-by: Yun Zhou <yun.zhou@windriver.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit d3b16034a24a112bb83aeb669ac5b9b01f744bb7)
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
lib/seq_buf.c