]> git.proxmox.com Git - mirror_ubuntu-impish-kernel.git/commit
ext4: return error code when ext4_fill_flex_info() fails
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 10 May 2021 11:10:51 +0000 (19:10 +0800)
committerAndrea Righi <andrea.righi@canonical.com>
Mon, 2 Aug 2021 11:26:49 +0000 (13:26 +0200)
commitc6a8313549ba933b6abbf41fd3697868fad09ef4
tree021c651a27d51da147e1a8a4edbb7928ce7ac982
parent64dbe362e5de585d55f7b92808d1dd11f63e054a
ext4: return error code when ext4_fill_flex_info() fails

After commit c89128a00838 ("ext4: handle errors on
ext4_commit_super"), 'ret' may be set to 0 before calling
ext4_fill_flex_info(), if ext4_fill_flex_info() fails ext4_mount()
doesn't return error code, it makes 'root' is null which causes crash
in legacy_get_tree().

Fixes: c89128a00838 ("ext4: handle errors on ext4_commit_super")
Reported-by: Hulk Robot <hulkci@huawei.com>
Cc: <stable@vger.kernel.org> # v4.18+
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210510111051.55650-1-yangyingliang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
(cherry picked from commit 8f6840c4fd1e7bd715e403074fb161c1a04cda73)
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
fs/ext4/super.c