]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
usb: dwc3: xilinx: fix uninitialized return value
authorRobert Hancock <robert.hancock@calian.com>
Thu, 27 Jan 2022 22:15:00 +0000 (16:15 -0600)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 3 Feb 2022 09:28:55 +0000 (10:28 +0100)
commit46fe811ba9051242d51c13dc645a234df08ea390
tree98fd37d45a99c4d054e790365b1d2eb1fc296bde
parentf1c2eef5f86b391a8337e0bd84a6bbec52361c09
usb: dwc3: xilinx: fix uninitialized return value

BugLink: https://bugs.launchpad.net/bugs/1959879
commit b470947c3672f7eb7c4c271d510383d896831cc2 upstream.

A previous patch to skip part of the initialization when a USB3 PHY was
not present could result in the return value being uninitialized in that
case, causing spurious probe failures. Initialize ret to 0 to avoid this.

Fixes: 9678f3361afc ("usb: dwc3: xilinx: Skip resets and USB3 register settings for USB2.0 mode")
Cc: <stable@vger.kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Link: https://lore.kernel.org/r/20220127221500.177021-1-robert.hancock@calian.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/usb/dwc3/dwc3-xilinx.c